Project

General

Profile

Actions
Copy link

Bug #53724

open

mds: stray directories are not purged when all past parents are clear

Added by Patrick Donnelly over 2 years ago. Updated about 1 year ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Dhairya Parmar
Category:
Correctness/Safety
Target version:
Ceph - v19.0.0
% Done:

0%

Source:
Development
Tags:
backport_processed
Backport:
reef,quincy,pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
scrub, snapshots, task(easy), task(intern)
Pull request ID:
47649
Crash signature (v1):
Crash signature (v2):

Description

(Note to experienced CephFS devs: let's save this for a newer dev!)

If a directory is not purged because it has past parents (due to snapshots), then it stays in the stray directory. If that snapshot is later removed, the stray directory will not be purged until the MDS is forcibly restarted (e.g. from `ceph mds fail X`). This happens in:

https://github.com/ceph/ceph/blob/7659877b16284516df102f60f866af9d0fa37bb3/src/mds/MDCache.cc#L9926

The fix to this bug either may be teaching scrub to evaluate all strays in the ~mdsdir or to regularly (~1 min?) evaluate strays.

Be sure to write tests for this. It can be reproduced by limiting the number of files in the stray directories using the configs mds_bal_fragment_size_max and mds_bal_split_size.

Related issues 3 (2 open — 1 closed)

Copied to CephFS - Backport #59260: reef: mds: stray directories are not purged when all past parents are clearIn ProgressDhairya ParmarActions
Copied to CephFS - Backport #59261: pacific: mds: stray directories are not purged when all past parents are clearResolvedDhairya ParmarActions
Copied to CephFS - Backport #59262: quincy: mds: stray directories are not purged when all past parents are clearIn ProgressDhairya ParmarActions
Actions
Copy link
 #1

Updated by Xiubo Li over 2 years ago

  • Status changed from New to In Progress
  • Assignee set to Xiubo Li
Actions
Copy link
 #2

Updated by Xiubo Li over 2 years ago

  • Status changed from In Progress to New
  • Assignee deleted (Xiubo Li)
Actions
Copy link
 #3

Updated by Xiubo Li over 2 years ago

Sorry, didn't carefully read the description, already renewed it :-)

Actions
Copy link
 #4

Updated by Dhairya Parmar about 2 years ago

  • Assignee set to Dhairya Parmar
Actions
Copy link
 #5

Updated by Dhairya Parmar almost 2 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #6

Updated by Patrick Donnelly almost 2 years ago

  • Target version deleted (v17.0.0)
Actions
Copy link
 #7

Updated by Xiubo Li over 1 year ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 47649
Actions
Copy link
 #8

Updated by Venky Shankar about 1 year ago

  • Category set to Correctness/Safety
  • Target version set to v19.0.0
  • Backport changed from pacific,octopus to reef,quincy,pacific
  • Labels (FS) scrub added
Actions
Copy link
 #9

Updated by Venky Shankar about 1 year ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #10

Updated by Dhairya Parmar about 1 year ago

  • Status changed from Resolved to Pending Backport
Actions
Copy link
 #11

Updated by Backport Bot about 1 year ago

  • Copied to Backport #59260: reef: mds: stray directories are not purged when all past parents are clear added
Actions
Copy link
 #12

Updated by Backport Bot about 1 year ago

  • Copied to Backport #59261: pacific: mds: stray directories are not purged when all past parents are clear added
Actions
Copy link
 #13

Updated by Backport Bot about 1 year ago

  • Copied to Backport #59262: quincy: mds: stray directories are not purged when all past parents are clear added
Actions
Copy link
 #14

Updated by Backport Bot about 1 year ago

  • Tags set to backport_processed
Actions
Copy link

Also available in: Atom PDF