Bug #47006
closed
mon: required client features adding/removing
Added by Jos Collin almost 4 years ago.
Updated over 3 years ago.
Category:
Correctness/Safety
Description
https://docs.ceph.com/docs/master/cephfs/administration/#minimum-client-version
fs required_client_features <fs name> add reply_encoding
fs required_client_features <fs name> rm reply_encoding
It is possible to add an already existing feature to a filesystem and remove a feature that doesn't exist in a filesystem? We need to add a check in FSCommands.cc
- Status changed from New to Need More Info
Can you elaborate on what the problem is? Give an example.
- Status changed from Need More Info to New
Patrick Donnelly wrote:
Can you elaborate on what the problem is? Give an example.
jcollin@smithi046:~/ceph/build$ ./bin/ceph fs dump| grep required_client_features
dumped fsmap epoch 12
required_client_features {}
jcollin@smithi046:~/ceph/build$ ./bin/ceph fs required_client_features a rm reply_encoding
removed feature 'reply_encoding' to required_client_features
jcollin@smithi046:~/ceph/build$ ./bin/ceph fs required_client_features a rm reply_encoding
removed feature 'reply_encoding' to required_client_features
jcollin@smithi046:~/ceph/build$ ./bin/ceph fs dump| grep required_client_features
dumped fsmap epoch 14
required_client_features {}
The same when using add command too. Is this intentional?
Jos Collin wrote:
Patrick Donnelly wrote:
Can you elaborate on what the problem is? Give an example.
[...]
The same when using add command too. Is this intentional?
Well, the command is idempotent. The message could be improved to say that the feature was not set. The exit code should still be 0.
- Status changed from New to Triaged
- Assignee set to Jos Collin
- Target version set to v16.0.0
- Status changed from Triaged to Fix Under Review
- Pull request ID set to 37359
- Status changed from Fix Under Review to Resolved
Also available in: Atom
PDF