Actions
Bug #46869
closedmgr/dashboard: SCSS modules are breaking our current way of branding the dashboard
% Done:
0%
Source:
Tags:
Backport:
Regression:
No
Severity:
2 - major
Reviewed:
Description
As of PR https://github.com/ceph/ceph/pull/35501 the dashboard branding doesn't work like before.
This means that we need to adjust some code and of course also the HACKING.rst (see: [[https://github.com/ceph/ceph/pull/35954#discussion_r466950052]])
Current issues:- We have direct import of variables from '_bootstrap-defaults.scss'. Changing vars in vendor files will not update this.
- We need to change the order of imports of '_bootstrap-defaults.scss' and 'vendor/variables'. ATM updating vendor variables is not updating the theme.
- the @import of ceph custom styles can significantly increased the size of the build, depending on the content of 'vendor/variables'
Updated by Tiago Melo over 3 years ago
- Subject changed from SCSS modules are breaking our current way of branding the dashboard to mgr/dashboard: SCSS modules are breaking our current way of branding the dashboard
Updated by Lenz Grimmer over 3 years ago
- Assignee set to Anonymous
- Target version set to v16.0.0
Updated by Alfonso Martínez over 3 years ago
- Related to Feature #45934: mgr/dashboard: Use SASS's new Modules instead of the old @import added
Updated by Alfonso Martínez over 3 years ago
- Status changed from New to In Progress
- Assignee changed from Anonymous to Alfonso Martínez
Updated by Alfonso Martínez over 3 years ago
- Status changed from In Progress to Fix Under Review
- Pull request ID set to 37617
Updated by Lenz Grimmer over 3 years ago
- Status changed from Fix Under Review to Resolved
Updated by Ernesto Puerta about 3 years ago
- Project changed from mgr to Dashboard
- Category changed from 165 to UI
Actions