Project

General

Profile

Actions

Bug #44113

closed

cephfs-shell: set proper return value for the tool

Added by Rishabh Dave about 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs-shell
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently, cephfs-shell tool returns zero all the time, whether the shell is in interactive or non-interactive mode -

$ cephfs-shell
CephFS:~/>>> mkdir z/y
ERROR: error in mkdir z/y: No such file or directory [Errno 2]
To enable full traceback, run the following command:  'set debug true'
CephFS:~/>>>
$ echo $?
0
$ cephfs-shell -- mkdir a/b
ERROR: error in mkdir a/b: No such file or directory [Errno 2]
To enable full traceback, run the following command:  'set debug true'
CephFS:~/>>> 
$ echo $?
0
$ cephfs-shell mkdir a/b
ERROR: error in mkdir a/b: No such file or directory [Errno 2]
To enable full traceback, run the following command:  'set debug true'
CephFS:~/>>> 
$ echo $?
0
(venv

Related issues 1 (0 open1 closed)

Copied to CephFS - Backport #46094: octopus: cephfs-shell: set proper return value for the toolRejectedPatrick DonnellyActions
Actions #1

Updated by Rishabh Dave about 4 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 32288

Actually, code for this was already present on the PR, just separated the commit; marking "Fix Under Review".

Actions #2

Updated by Rishabh Dave about 4 years ago

  • Assignee set to Rishabh Dave
Actions #3

Updated by Patrick Donnelly almost 4 years ago

  • Target version set to v16.0.0
  • Source set to Development
  • Backport set to octopus
Actions #4

Updated by Patrick Donnelly almost 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #5

Updated by Patrick Donnelly almost 4 years ago

  • Copied to Backport #46094: octopus: cephfs-shell: set proper return value for the tool added
Actions #6

Updated by Nathan Cutler over 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions

Also available in: Atom PDF