Project

General

Profile

Actions

Bug #43027

closed

mgr/dashboard: Improve iSCSI IQN validation message when spaces are used

Added by Ricardo Marques over 4 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Ricardo Marques
Category:
Component - iSCSI
Target version:
% Done:

0%

Source:
Tags:
low-hanging-fruit
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

If I try to create an iSCSI target with a space in the IQN, I see the following message:

It's hard no notice that I'm using a space, especially if space appears in the beginning or in the end.

To fix this, we should have a dedicated error message for this scenario.


Files

iqn_spaces_before.png (12 KB) iqn_spaces_before.png Ricardo Marques, 11/26/2019 11:42 AM

Related issues 1 (0 open1 closed)

Copied to Dashboard - Backport #43083: nautilus: mgr/dashboard: Improve iSCSI IQN validation message when spaces are usedResolvedRicardo MarquesActions
Actions #1

Updated by Lenz Grimmer over 4 years ago

That's indeed a "gotcha" which can likely happen when cut & pasting IQNs from another application or email message. Would it make sense to automatically trim white space here instead?

Actions #2

Updated by Ricardo Marques over 4 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Ricardo Marques over 4 years ago

Lenz Grimmer wrote:

That's indeed a "gotcha" which can likely happen when cut & pasting IQNs from another application or email message. Would it make sense to automatically trim white space here instead?

Agree. I'll do that.

Actions #4

Updated by Ricardo Marques over 4 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 31888
Actions #5

Updated by Lenz Grimmer over 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #6

Updated by Ricardo Marques over 4 years ago

  • Copied to Backport #43083: nautilus: mgr/dashboard: Improve iSCSI IQN validation message when spaces are used added
Actions #7

Updated by Nathan Cutler over 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions #8

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 141 to Component - iSCSI
Actions

Also available in: Atom PDF