Project

General

Profile

Actions
Copy link

Bug #41429

closed

Incorrect logical operator in Monitor::handle_auth_request()

Added by yupeng chen over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Ceph - v15.0.0
% Done:

0%

Source:
Community (user)
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
Ceph - v14.2.3
ceph-qa-suite:
Component(RADOS):
Monitor
Pull request ID:
30015
Crash signature (v1):
Crash signature (v2):

Description

When checking auth_mode against AUTH_MODE_MON and AUTH_MODE_MON_MAX in Monitor::handle_auth_request(),
a logical AND (&&) operator produces a contradiction.

Related issues 1 (0 open — 1 closed)

Copied to RADOS - Backport #41705: nautilus: Incorrect logical operator in Monitor::handle_auth_request()ResolvedNathan CutlerActions
Actions
Copy link
 #1

Updated by yupeng chen over 4 years ago

“&&” in the following code snippet:

  } else if (auth_meta->auth_mode < AUTH_MODE_MON &&

         auth_meta->auth_mode > AUTH_MODE_MON_MAX) {
    derr << __func__ << " unrecognized auth mode " << auth_meta->auth_mode
     << dendl;
    return -EACCES;
  }
Actions
Copy link
 #2

Updated by Patrick Donnelly over 4 years ago

  • Project changed from Ceph to RADOS
  • Category deleted (Monitor)
  • Target version changed from v14.2.2 to v15.0.0
  • Start date deleted (08/26/2019)
  • Backport set to nautilus,mimic
  • Affected Versions deleted (v14.2.0, v14.2.1, v14.2.2, v15.0.0)
  • Component(RADOS) Monitor added
Actions
Copy link
 #3

Updated by Neha Ojha over 4 years ago

  • Assignee set to Neha Ojha
  • Backport deleted (nautilus,mimic)
Actions
Copy link
 #4

Updated by Neha Ojha over 4 years ago

  • Status changed from New to Fix Under Review
  • Backport set to nautilus
  • Pull request ID set to 30015
Actions
Copy link
 #5

Updated by Kefu Chai over 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #6

Updated by Kefu Chai over 4 years ago

  • Assignee deleted (Neha Ojha)
Actions
Copy link
 #7

Updated by Nathan Cutler over 4 years ago

  • Copied to Backport #41705: nautilus: Incorrect logical operator in Monitor::handle_auth_request() added
Actions
Copy link
 #8

Updated by Nathan Cutler over 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF