Project

General

Profile

Actions

Cleanup #40578

closed

mds: reorganize class members in headers to follow coding guidelines

Added by Patrick Donnelly almost 5 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Code Hygiene
Target version:
% Done:

100%

Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
MDS
Labels (FS):
task(easy)
Pull request ID:

Description

Guide here: https://google.github.io/styleguide/cppguide.html#Declaration_Order

A past commit that has improved this: https://github.com/ceph/ceph/commit/36f3bc067f0971d490ab4aabe4feab2996138275

All of the MDS headers should follow these guidelines. This is especially helpful in identifying the public interface to a MDS class. Right now many MDS headers mix private/public in ways that makes understanding the class very difficult. For example:

https://github.com/ceph/ceph/blob/8ba339a41b2178cb27d4421bc512f3e622824d1d/src/mds/MDCache.h#L1108-L1130


Subtasks 43 (0 open43 closed)

Cleanup #40742: mds: reorg CDir headerResolvedVarsha Rao

Actions
Cleanup #40787: mds: reorg CInode headerResolvedVarsha Rao

Actions
Cleanup #40866: mds: reorg Capability headerResolvedVarsha Rao

Actions
Cleanup #41178: mds: reorg DamageTable headerResolvedVarsha Rao

Actions
Cleanup #41181: mds: reorg FSMap headerResolvedVarsha Rao

Actions
Cleanup #41185: mds: reorg FSMapUser headerResolvedVarsha Rao

Actions
Cleanup #41428: mds: reorg InoTable headerResolvedVarsha Rao

Actions
Cleanup #41430: mds: reorg JournalPointer headerResolvedVarsha Rao

Actions
Cleanup #41607: mds: reorg Anchor headerResolvedVarsha Rao

Actions
Bug #41654: mds: reorg LocalLock headerResolvedVarsha Rao

Actions
Cleanup #41665: mds: reorg Locker headerResolvedVarsha Rao

Actions
Cleanup #41678: mds: reorg LogSegment headerResolvedVarsha Rao

Actions
Cleanup #41679: mds: reorg LogEvent headerResolvedVarsha Rao

Actions
Cleanup #42043: mds: reorg MDBalancer headerResolvedVarsha Rao

Actions
Cleanup #42191: mds: reorg MDCache headerResolvedVarsha Rao10/07/2019

Actions
Cleanup #42192: mds: reorg MDLog headerResolvedVarsha Rao10/07/2019

Actions
Cleanup #42311: mds: reorg MDSAuthCaps headerResolvedVarsha Rao

Actions
Cleanup #42329: mds: reorg MDSCacheObject headerResolvedVarsha Rao

Actions
Cleanup #42371: mds: reorg MDSDaemon headerResolvedVarsha Rao

Actions
Cleanup #42461: mds: reorg MDSTableClient headerResolvedVarsha Rao

Actions
Cleanup #42464: mds: reorg MDSMap headerResolvedVarsha Rao

Actions
Cleanup #42465: mds: reorg MDSRank headerResolvedVarsha Rao

Actions
Cleanup #42468: mds: reorg MDSTable headerResolvedVarsha Rao

Actions
Cleanup #42563: mds: reorg MDSTableServer headerResolvedVarsha Rao

Actions
Cleanup #42564: mds: reorg Migrator headerResolvedVarsha Rao

Actions
Cleanup #42690: mds: reorg Mutation headerResolvedVarsha Rao

Actions
Cleanup #42792: mds: reorg OpenFileTable headerResolvedVarsha Rao

Actions
Cleanup #42793: mds: reorg PurgeQueue headerResolvedVarsha Rao

Actions
Cleanup #42813: mds: reorg RecoveryQueue headerResolvedVarsha Rao

Actions
Cleanup #42864: mds: reorg ScatterLock headerResolvedVarsha Rao

Actions
Cleanup #42865: mds: reorg ScrubHeader headerResolvedVarsha Rao

Actions
Cleanup #42866: mds: reorg ScrubStack headerResolvedVarsha Rao

Actions
Cleanup #42867: mds: reorg Server headerResolvedVarsha Rao

Actions
Cleanup #43366: mds: reorg SessionMap headerResolvedVarsha Rao

Actions
Cleanup #43367: mds: reorg SimpleLock headerResolvedVarsha Rao

Actions
Cleanup #43369: mds: reorg SnapClient headerResolvedVarsha Rao

Actions
Cleanup #43386: mds: reorg SnapRealm headerResolvedVarsha Rao

Actions
Cleanup #43387: mds: reorg SnapServer headerResolvedVarsha Rao

Actions
Cleanup #43408: mds: reorg StrayManager headerResolvedVarsha Rao

Actions
Cleanup #43418: mds: reorg flock headerResolvedVarsha Rao

Actions
Cleanup #43424: mds: reorg inode_backtrace headerResolvedVarsha Rao

Actions
Cleanup #43425: mds: reorg snap headerResolvedVarsha Rao

Actions
Cleanup #43426: mds: reorg mdstypes headerResolvedVarsha Rao

Actions
Actions #1

Updated by Jos Collin almost 5 years ago

  • Pull request ID set to 28860
Actions #2

Updated by Patrick Donnelly almost 5 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Patrick Donnelly almost 5 years ago

  • Tracker changed from Bug to Cleanup
Actions #4

Updated by Patrick Donnelly about 4 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF