Bug #39554: qa: TypeError: run() got an unexpected keyword argument 'omit_sudo' - teuthology - Ceph

Actions

Copy link

Bug #39554

closed

qa: TypeError: run() got an unexpected keyword argument 'omit_sudo'

Added by Patrick Donnelly almost 5 years ago. Updated almost 5 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Patrick Donnelly

Category:

% Done:

Source:

Q/A

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Crash signature (v1):

Crash signature (v2):

Description

2019-04-25T16:42:19.823 INFO:tasks.cephfs_test_runner:======================================================================
2019-04-25T16:42:19.824 INFO:tasks.cephfs_test_runner:ERROR: test_kill_mdstable (tasks.cephfs.test_snapshots.TestSnapshots)
2019-04-25T16:42:19.824 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2019-04-25T16:42:19.824 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2019-04-25T16:42:19.825 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-pdonnell-testing-20190424.232741/qa/tasks/cephfs/test_snapshots.py", line 55, in test_kill_mdstable
2019-04-25T16:42:19.825 INFO:tasks.cephfs_test_runner:    self.mount_a.run_shell(["mkdir", "-p", "d1/dir"])
2019-04-25T16:42:19.825 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-pdonnell-testing-20190424.232741/qa/tasks/cephfs/mount.py", line 191, in run_shell
2019-04-25T16:42:19.827 INFO:tasks.cephfs_test_runner:    omit_sudo=omit_sudo)
2019-04-25T16:42:19.827 INFO:tasks.cephfs_test_runner:  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 193, in run
2019-04-25T16:42:19.828 INFO:tasks.cephfs_test_runner:    r = self._runner(client=self.ssh, name=self.shortname, **kwargs)
2019-04-25T16:42:19.828 INFO:tasks.cephfs_test_runner:TypeError: run() got an unexpected keyword argument 'omit_sudo'

From: /ceph/teuthology-archive/pdonnell-2019-04-25_02:44:21-multimds-wip-pdonnell-testing-20190424.232741-distro-basic-smithi/3890961/teuthology.log

Caused by: https://github.com/ceph/ceph/pull/27481

Actions

Copy link

Updated by Rishabh Dave almost 5 years ago

Status changed from New to In Progress

Looks like there are 2 issues here. First, run.Raw is not exempted from the checks that were supposed to be on strings. I've written a patch for this and pushed it as a commit to PR 27718. I wrote a minor test for verifying my fix: I passed ['ls', '&&', 'ls'] to the run_shell() and it worked fine.

Second issue is that value of core_file is "|/usr/lib/systemd" which is weird because the string has a vertical bar at the beginning and, more importantly, because "/usr/lib/systemd" is not a directory and the following lines of code will attempt to use it as the target directory for "cd" command. Following is the traceback obtained from running "test_kill_mdstable"

File "/home/rishabh/repos/ceph/pr-27718/qa/tasks/cephfs/test_snapshots.py", line 76, in test_kill_mdstable
    self.delete_mds_coredump(rank0['name']);
  File "/home/rishabh/repos/ceph/pr-27718/qa/tasks/cephfs/cephfs_test_case.py", line 268, in delete_mds_coredump
    ], stdout=StringIO())
  File "../qa/tasks/vstart_runner.py", line 346, in run
    proc.wait()
  File "../qa/tasks/vstart_runner.py", line 179, in wait
    raise CommandFailedError(self.args, self.exitstatus)
CommandFailedError: Command failed with status 1: ['cd', '|/usr/lib/systemd', Raw('&&'), 'ls', Raw('|'), 'xargs', 'file']

Actions

Copy link