Project

General

Profile

Bug #39510

test_volume_client: test_put_object_versioned is unreliable

Added by Rishabh Dave about 2 months ago. Updated about 1 month ago.

Status:
Need Review
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
04/28/2019
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
nautilus,mimic,luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:

Description

test_put_object_versioned in test_volume_client.py succeeds if it receives a CommandFailedError exception from the embedded python program. This manner of testing is unreliable since the embedded python program contains multiple statements and the same exception may be raised by any of those. This has happened twice AFAIR: first, the test never failed despite of the fact that ceph_volume_client.py's put_object_versioned() was buggy[1] and second while i am working to make the embedded python programs in test_volume_client.py python3 compatible. Therefore, it's best to rewrite this test so it doesn't depend on a generic exception for passing[2].

I'll add a commit for this to [2].

History

#1 Updated by Patrick Donnelly about 1 month ago

  • Status changed from In Progress to Need Review
  • Target version set to v15.0.0
  • Source set to Development
  • Backport set to nautilus,mimic,luminous
  • Pull request ID set to 27718

Also available in: Atom PDF