Actions
Cleanup #38003
closedmgr/dashboard: Avoid merge conflicts in messages.xlf by auto-generating it at build time?
% Done:
0%
Tags:
Backport:
nautilus
Reviewed:
Affected Versions:
Pull request ID:
Description
Currently, the file ./src/pybind/mgr/dashboard/frontend/src/locale/messages.xlf needs to be updated by running "npm run i18n" every time when changes to the UI have been made that affect translatable strings. The modified messages.xlf file then needs to be commited and is part of the changeset. This approach has several issues:
- As this file potentially gets modified by many pull requests, it becomes a "hot spot", requiring lots of rebasing and resolving of conflicts
- Including the messages.xlf file in the same commit as other changes makes it more difficult to back-port such a change to older releases, where the messages.xlf might differ significantly
Would it make sense to treat this file as an asset that gets generated at build time instead, taking it out of git revision control?
Updated by Lenz Grimmer almost 5 years ago
- Has duplicate Cleanup #39627: mgr/dashboard: Remove messages.xlf file added
Updated by Lenz Grimmer almost 5 years ago
- Assignee set to Anonymous
- Backport set to nautilus
Updated by Anonymous almost 5 years ago
- Status changed from New to Fix Under Review
Updated by Lenz Grimmer almost 5 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Ricardo Marques almost 5 years ago
- Copied to Backport #39658: nautilus: mgr/dashboard: Avoid merge conflicts in messages.xlf by auto-generating it at build time? added
Updated by Lenz Grimmer almost 5 years ago
- Target version set to v15.0.0
- Affected Versions v14.0.0, v14.2.0, v14.2.1, v15.0.0 added
Updated by Tiago Melo almost 5 years ago
- Status changed from Pending Backport to Resolved
Updated by Ernesto Puerta about 3 years ago
- Project changed from mgr to Dashboard
- Category changed from 147 to i18n
Actions