Project

General

Profile

Actions

Bug #343

closed

Bad 100-Continue handling

Added by Yehuda Sadeh over 13 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

When uploading a file onboth fcgid and fastcgi, the PUT request with the 'Expect: 100-Continue' triggers an automatic 100-Continue response from the server without giving the gateway a chance to respond differently (e.g., when there's no permissions). This leads to the client uploading the entire file and only then does it get the permission denied response.

It might be a problem with the fastcgi/fcgid implementation, and could be that due to buffering it reads more than the header before going to the gateway, which triggers the apache automatic response. Should investigate more into this and if that is the case we might be able to modify fastcgi so that it doesn't do that.


Files

fastcgi-cont3.patch (5.81 KB) fastcgi-cont3.patch Yehuda Sadeh, 09/03/2010 04:49 PM
Actions #1

Updated by Yehuda Sadeh over 13 years ago

Yes, the problem is with the fastcgi module. It calls ap_get_client_block() without waiting for any input from the 'server'. We can try modifying this behavior and make it so that when exepect-100-continue is requested, we should first wait for the server to send a status response before actually calling it.

Actions #2

Updated by Yehuda Sadeh over 13 years ago

  • File fastcgi-cont.patch added
Actions #3

Updated by Yehuda Sadeh over 13 years ago

  • File deleted (fastcgi-cont.patch)
Actions #4

Updated by Yehuda Sadeh over 13 years ago

  • File fastcgi-cont2.patch added

We probably need to setup a git repository for the fastcgi apache module.

Actions #5

Updated by Yehuda Sadeh over 13 years ago

  • File deleted (fastcgi-cont2.patch)
Actions #7

Updated by Yehuda Sadeh about 13 years ago

  • Status changed from New to 7
Actions #8

Updated by Yehuda Sadeh about 13 years ago

  • Status changed from 7 to Resolved

Ok, tested it quite a bit and it seems that it's working without any problems. It's commit:3fed7a553db315a855f3b2f697e05e5402123424 of the mod_fastcgi tree.

Actions #9

Updated by Sage Weil about 13 years ago

  • Category set to radosgw
Actions #10

Updated by Sage Weil about 13 years ago

  • Project changed from 4 to Ceph
  • Category changed from radosgw to 22
Actions #11

Updated by John Spray over 6 years ago

  • Project changed from Ceph to rgw
  • Category deleted (22)

Bulk reassign of radosgw category to RGW project.

Actions

Also available in: Atom PDF