Bug #23262: kclient: nofail option not supported - CephFS - Ceph

Actions

Copy link

Bug #23262

closed

kclient: nofail option not supported

Added by Kenneth Waegeman about 6 years ago. Updated almost 5 years ago.

Status:

Resolved

Priority:

High

Assignee:

Kenneth Waegeman

Category:

Target version:

Ceph - v15.0.0

% Done:

Source:

Community (user)

Tags:

Backport:

nautilus,mimic,luminous

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

Ceph - v12.2.2, Ceph - v12.2.3, Ceph - v12.2.4

ceph-qa-suite:

Component(FS):

kceph

Labels (FS):

Pull request ID:

26992

Crash signature (v1):

Crash signature (v2):

Description

I get an invalid argument when trying to mount ceph with nofail option
mon01,mon02,mon03:/ /mnt/ceph ceph name=cephfs,secretfile=/etc/ceph/secret,noatime,nofail 0 0
or
[root@osd003 ~]# mount -t ceph mon01,mon02,mon03:/ /mnt/ceph -o name=admin,secretfile=/etc/ceph/secret,noatime,nofail
mount error 22 = Invalid argument

Without nofail the mount succeeds.

I am running centos7.4 3.10.0-693.17.1.el7. ceph cluster running 12.2.4

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Chengguang Xu almost 6 years ago

It seems mount command cannot recognize nofail option, not ceph or ceph kernel client.
What version of util-linux do you use? Can you upgrade util-linux to 2.32 and a test again?

Actions

Copy link

Updated by Kenneth Waegeman almost 6 years ago

We are running the latest util-linux of centos 7.5, util-linux-2.23.2-52.el7.x86_64.
If we mount another fs type with mount, nofail works (eg tested with NFS), but not with mount.ceph

Actions

Copy link

Updated by Ilya Dryomov over 5 years ago

The issue is that mount.ceph helper doesn't handle nofail, but passes it through to the kernel. nofail is a userspace level option, it shouldn't be making it to the kernel.

mount.ceph.c should be taught to handle nofail: not just skip it, but return success if things like address resolution fail, etc.

Actions

Copy link

Updated by Ilya Dryomov over 5 years ago

Project changed from Linux kernel client to CephFS
Component(FS) kceph added

Actions

Copy link

Updated by Patrick Donnelly over 5 years ago

Subject changed from nofail option not supported to kclient: nofail option not supported
Assignee set to Zheng Yan
Priority changed from Normal to High
Target version set to v14.0.0
Backport set to mimic,luminous