Project

General

Profile

Actions
Copy link

Backport #23223

closed

luminous: rgw: garbage collector removes objects slowly

Added by Nathan Cutler about 6 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jesse Williamson
Target version:
Ceph - v12.2.13
Release:
luminous
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

https://github.com/ceph/ceph/pull/28784

Related issues 1 (0 open — 1 closed)

Copied from rgw - Bug #23139: rgw: garbage collector removes objects slowlyResolved02/26/2018

Actions
Actions
Copy link
 #1

Updated by Nathan Cutler about 6 years ago

  • Copied from Bug #23139: rgw: garbage collector removes objects slowly added
Actions
Copy link
 #2

Updated by Prashant D about 6 years ago

  • Status changed from New to Need More Info

I am getting compilation error for one of the rgw testcase:
[ 94%] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_period_pusher.cc.o
/home/pdvian/backport/ceph6/src/rgw/rgw_gc.cc: In member function ‘int RGWGCIOManager::schedule_io(librados::IoCtx*, const string&, librados::ObjectWriteOperation*, int, const string&)’:
/home/pdvian/backport/ceph6/src/rgw/rgw_gc.cc:178:52: error: no matching function for call to ‘RGWGCIOManager::IO::IO’
ios.push_back(IO{IO::TailIO, c, oid, index, tag});
^
/home/pdvian/backport/ceph6/src/rgw/rgw_gc.cc:135:10: note: candidate: RGWGCIOManager::IO::IO
struct IO {
^~
/home/pdvian/backport/ceph6/src/rgw/rgw_gc.cc:135:10: note: candidate expects 0 arguments, 5 provided
/home/pdvian/backport/ceph6/src/rgw/rgw_gc.cc:135:10: note: candidate: RGWGCIOManager::IO::IO
/home/pdvian/backport/ceph6/src/rgw/rgw_gc.cc:135:10: note: candidate expects 1 argument, 5 provided
/home/pdvian/backport/ceph6/src/rgw/rgw_gc.cc:135:10: note: candidate: RGWGCIOManager::IO::IO
/home/pdvian/backport/ceph6/src/rgw/rgw_gc.cc:135:10: note: candidate expects 1 argument, 5 provided
make3: * [src/rgw/CMakeFiles/rgw_a.dir/build.make:523: src/rgw/CMakeFiles/rgw_a.dir/rgw_gc.cc.o] Error 1
make3: Waiting for unfinished jobs....
make2: [CMakeFiles/Makefile2:23127: src/rgw/CMakeFiles/rgw_a.dir/all] Error 2
make1: [CMakeFiles/Makefile2:234: CMakeFiles/tests.dir/rule] Error 2
make: ** [Makefile:175: tests] Error 2

the build environment is :
$ cat /etc/fedora-release
Fedora release 26 (Twenty Six)
$ g++ --version
g++ (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)

Actions
Copy link
 #3

Updated by Nathan Cutler almost 6 years ago

non-trivial backport, could an RGW developer please take it

Actions
Copy link
 #4

Updated by Nathan Cutler almost 5 years ago

  • Assignee set to Casey Bodley
Actions
Copy link
 #5

Updated by Jesse Williamson almost 5 years ago

  • Assignee changed from Casey Bodley to Jesse Williamson
Actions
Copy link
 #7

Updated by Jesse Williamson almost 5 years ago

PR: https://github.com/ceph/ceph/pull/28784
- backports AIO garbage collection to luminous
- includes patch for C++11 compatibility

It's been quite a while since I've done a backport, please let me know if I missed something.

Thank you!

(Update: I see that Matt already put in a PR, feel free to disregard this if that's ready to go.)

Actions
Copy link
 #8

Updated by Casey Bodley almost 5 years ago

  • Status changed from Need More Info to In Progress
Actions
Copy link
 #9

Updated by Nathan Cutler almost 5 years ago

  • Description updated (diff)
Actions
Copy link
 #10

Updated by Yuri Weinstein almost 5 years ago

Nathan Cutler wrote:

https://github.com/ceph/ceph/pull/28784

merged

Actions
Copy link
 #11

Updated by Nathan Cutler almost 5 years ago

  • Status changed from In Progress to Resolved
  • Target version set to v12.2.13
Actions
Copy link
 #12

Updated by Nathan Cutler over 4 years ago

This update was made using the script "backport-resolve-issue".
backport PR https://github.com/ceph/ceph/pull/28784
merge commit acbd66c9a03f87cac63a96592d0a90cdc0039866 (v12.2.12-227-gacbd66c9a0)

Actions
Copy link

Also available in: Atom PDF