Project

General

Profile

Feature #22747

Add units to performance counters

Added by John Spray about 1 year ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
MgrClient
Target version:
-
Start date:
01/22/2018
Due date:
% Done:

0%

Source:
Tags:
Backport:
luminous
Reviewed:
Affected Versions:
Pull request ID:

Description

Currently, our performance counters don't indicate whether they are just generic counts (e.g. number of requests), or something with a unit (e.g. number of bytes).

It would be neat to add this in perf_counters.h and then expose it in "perf schema dump" and all the way up the ceph-mgr stack, so that consumers like the dashboard can know how to display things nicely.

The path that stats take to the manager starts in MgrClient::send_report, where a PerfCounterType is composed and inserted into the ::declare_types field of MMgrReport. Then when DaemonServer is handling the report, it passes the message through DaemonPerfCounters::update, which stashes the PerfCounterType.

So: the performance counter definitions in perf_counters.h will need a unit field, as will PerfCounterType, and PerfCounterType's encode/decode member functions will need to include the unit field. (Note on encode/decode functions: the ENCODE_START/DECODE_START functions take a version, which will need to be incremented from its current value of 2. Then you can add a new field to the end of encode, and in the end of decode. The decode of the new field should be conditional on the version, the same as the "priority" field in PerfCounterType currently is).


Related issues

Copied to mgr - Backport #25117: luminous: mgr: add units to performance counters (dashboard_v2 req.) Resolved

History

#1 Updated by John Spray about 1 year ago

  • Status changed from New to Need Review
  • Assignee set to Rubab Syed

#2 Updated by John Spray about 1 year ago

  • Status changed from Need Review to Resolved

#3 Updated by Ernesto Puerta 8 months ago

  • Status changed from Resolved to Pending Backport
  • Backport set to luminous

#4 Updated by Ernesto Puerta 8 months ago

  • Related to Backport #25117: luminous: mgr: add units to performance counters (dashboard_v2 req.) added

#6 Updated by Nathan Cutler 8 months ago

  • Related to deleted (Backport #25117: luminous: mgr: add units to performance counters (dashboard_v2 req.))

#7 Updated by Nathan Cutler 8 months ago

  • Copied to Backport #25117: luminous: mgr: add units to performance counters (dashboard_v2 req.) added

#8 Updated by Nathan Cutler 7 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF