Actions
Bug #21083
openclient: clean up header to isolate real public methods and entry points for client_lock
% Done:
0%
Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
With the recent revelation that the client_lock was not locked for Client::getcwd [1] and other history of missing locks [2], we should take the time to cleanup Client.h (and Client.cc) and verify that all public methods get the required locks. If it followed the current header organization coding standards, it would be easier to verify. Additionally, some methods which are public should probably be private.
[1] http://tracker.ceph.com/issues/21082
[2] https://github.com/ceph/ceph/pull/10027
Actions