Cleanup #20604
closed
Added by Ilya Dryomov almost 7 years ago.
Updated over 6 years ago.
Description
<sage> btw i just noticed kclient is still sending write,startsync .. that startsync is a no-op (has been for years) and can probably be removed
Files
I believe you are talking about OP_STARTSYNC = 27, // start a sync
present inside class ObjectStore::Transaction
- Status changed from New to In Progress
This ticket is for the kernel client -- don't close until it's done there as well.
@Ilya: Yes we are aware of that.
- Assignee set to Amit Kumar
I use ceph-client master branch to fix this, see attachment.
Kernel client should be sent to ceph-devel as plain text.
I took a quick look, in ceph_direct_read_write() you removed the "/*include a 'startsync' command*/" comment, but ceph_osdc_new_request() is still called with num_ops == 2 for writes, reserving a slot for startsync op.
@Ilya: OK, I'll check again
- Status changed from In Progress to Resolved
The kernel client patch is in 4.14 queue.
Also available in: Atom
PDF