Project

General

Profile

Actions
Copy link

Cleanup #20604

closed

startsync can be removed

Added by Ilya Dryomov almost 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Amit Kumar
Category:
fs/ceph
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:

Description

<sage> btw i just noticed kclient is still sending write,startsync .. that startsync is a no-op (has been for years) and can probably be removed

Files

0001-ceph-kernel-client-startsync-can-be-removed.patch (4.27 KB) 0001-ceph-kernel-client-startsync-can-be-removed.patch Yanhu Cao, 07/20/2017 02:33 AM
Actions
Copy link
 #1

Updated by Amit Kumar almost 7 years ago

I believe you are talking about OP_STARTSYNC = 27, // start a sync
present inside class ObjectStore::Transaction

Actions
Copy link
 #3

Updated by Jos Collin almost 7 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #4

Updated by Ilya Dryomov almost 7 years ago

This ticket is for the kernel client -- don't close until it's done there as well.

Actions
Copy link
 #5

Updated by Jos Collin almost 7 years ago

@Ilya: Yes we are aware of that.

Actions
Copy link
 #6

Updated by Sage Weil almost 7 years ago

  • Assignee set to Amit Kumar
Actions
Copy link
 #7

Updated by Yanhu Cao almost 7 years ago

I use ceph-client master branch to fix this, see attachment.

Actions
Copy link
 #8

Updated by Ilya Dryomov almost 7 years ago

Kernel client should be sent to ceph-devel as plain text.

I took a quick look, in ceph_direct_read_write() you removed the "/*include a 'startsync' command*/" comment, but ceph_osdc_new_request() is still called with num_ops == 2 for writes, reserving a slot for startsync op.

Actions
Copy link
 #9

Updated by Yanhu Cao almost 7 years ago

@Ilya: OK, I'll check again

Actions
Copy link
 #10

Updated by Jos Collin over 6 years ago

PR: https://github.com/ceph/ceph/pull/16396 is merged. This tracker is now waiting for the kclient to be fixed.

Actions
Copy link
 #11

Updated by Ilya Dryomov over 6 years ago

  • Status changed from In Progress to Resolved

The kernel client patch is in 4.14 queue.

Actions
Copy link

Also available in: Atom PDF