Actions
Bug #20430
closedcrush_location_hook does not work with Luminous
Status:
Resolved
Priority:
High
Assignee:
-
Category:
OSD
Target version:
-
% Done:
0%
Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Description
Trying with the Luminous RC it seems that the crush_location_hook isn't invoked.
The OSDs always seem to add themselves to root=default host=xyz
Looking at the source code the culprit seems to be in crush/CrushLocation.h
public: CrushLocation(CephContext *c) : cct(c) { update_from_conf(); } int update_from_conf(); ///< refresh from config int update_from_hook(); ///< call hook, if present int init_on_startup(); std::multimap<std::string,std::string> get_location() { std::lock_guard<std::mutex> l(lock); return loc; } };
update_from_conf() is called in the constructor, but to me it seems that init_on_startup() should be called
Updated by Wido den Hollander almost 7 years ago
Updated by Josh Durgin almost 7 years ago
- Status changed from New to Fix Under Review
Updated by xie xingguo almost 7 years ago
- Status changed from Fix Under Review to Resolved
Actions