Project

General

Profile

Actions

Bug #20424

closed

doc: improve description of `mds deactivate` to better contrast with `mds fail`

Added by Patrick Donnelly almost 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Administration/Usability
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently the help output is not very useful for `ceph mds deactivate`:

$ bin/ceph mds deactivate
Invalid command:  missing required parameter who(<string>)
mds deactivate <who> :  stop mds
Error EINVAL: invalid command

vs.

$ bin/ceph mds fail
Invalid command:  missing required parameter who(<string>)
mds fail <who> :  force mds to status failed
Error EINVAL: invalid command

Likewise, the man page is confusing and incomplete:

http://docs.ceph.com/docs/master/cephfs/administration/#daemons

Actions #1

Updated by Patrick Donnelly almost 7 years ago

It may be useful to change the names of these commands to be more intuitive.

Actions #2

Updated by John Spray almost 7 years ago

  • Status changed from New to Fix Under Review

In the absence of inspiration for better names:

https://github.com/ceph/ceph/pull/16080

It would be really nice to wrap up the max_mds+deactivate stuff into a single shrink command at some point

Actions #3

Updated by Patrick Donnelly almost 7 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF