Actions
Bug #19853
closedcmake modules should set proper package name
% Done:
0%
Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Description
in ceph/cmake/modules/Findcryptopp.cmake, it uses
FIND_PACKAGE_HANDLE_STANDARD_ARGS (CryptoPP REQUIRED_VARS CRYPTOPP_ROOT_DIR
the package name here is CryptoPP, not cryptopp, which all letters are lower-case。
the file name is also lower-case.
And in ceph/CMakeLists.txt, it uses `find_package(cryptopp REQUIRED)`, which is lower-case.
The result is that, during cmake, it only outputs `Could NOT find CryptoPP` without any fault, but it should abort the whole cmake process.
You can produce this by removing cryptopp library from your system and run cmake with -DWITH_NSS=OFF so that cryptopp can be used.
Besides, I think there are others files in ceph/cmake/modules using the wrong package name.
Actions