https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2017-05-04T07:27:03ZCeph Ceph - Bug #19853: cmake modules should set proper package namehttps://tracker.ceph.com/issues/19853?journal_id=907302017-05-04T07:27:03ZNathan Cutlerncutler@suse.cz
<ul></ul><blockquote>
<p>the package name here is CryptoPP, not cryptopp, which all letters are lower-case</p>
</blockquote>
<p>The package name is CryptoPP in which distribution? In openSUSE, for example, the package name appears to be libcryptopp.</p>
<p><a class="external" href="https://build.opensuse.org/package/view_file/openSUSE:Factory/libcryptopp/libcryptopp.spec?expand=1">https://build.opensuse.org/package/view_file/openSUSE:Factory/libcryptopp/libcryptopp.spec?expand=1</a></p> Ceph - Bug #19853: cmake modules should set proper package namehttps://tracker.ceph.com/issues/19853?journal_id=907312017-05-04T07:32:32ZShengjing Zhu
<ul></ul><p>Nathan Cutler wrote:</p>
<blockquote><blockquote>
<p>the package name here is CryptoPP, not cryptopp, which all letters are lower-case</p>
</blockquote>
<p>The package name is CryptoPP in which distribution? In openSUSE, for example, the package name appears to be libcryptopp.</p>
<p><a class="external" href="https://build.opensuse.org/package/view_file/openSUSE:Factory/libcryptopp/libcryptopp.spec?expand=1">https://build.opensuse.org/package/view_file/openSUSE:Factory/libcryptopp/libcryptopp.spec?expand=1</a></p>
</blockquote>
<p>Hi, it's no matter how the system name the library. Actually the file Findcryptopp.cmake is to find the library in different distributions.</p>
<p>The problem here is how to name it in cmake file. If you use <strong>CryptoPP</strong> in FIND_PACKAGE_HANDLE_STANDARD_ARGS(cmake func), then you should name the module file with FindCryptoPP.cmake, and use CryptoPP in find_package(cmake func). Or use lower-case all the places.</p> Ceph - Bug #19853: cmake modules should set proper package namehttps://tracker.ceph.com/issues/19853?journal_id=907352017-05-04T08:35:32ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Fix Under Review</i></li><li><strong>Assignee</strong> set to <i>Nathan Cutler</i></li></ul><p><a class="external" href="https://github.com/ceph/ceph/pull/14951">https://github.com/ceph/ceph/pull/14951</a></p> Ceph - Bug #19853: cmake modules should set proper package namehttps://tracker.ceph.com/issues/19853?journal_id=907362017-05-04T08:36:10ZNathan Cutlerncutler@suse.cz
<ul></ul><p>@Shengjing Zhu: Thanks for the explanation. Opened a PR with a fix - please review.</p> Ceph - Bug #19853: cmake modules should set proper package namehttps://tracker.ceph.com/issues/19853?journal_id=907372017-05-04T09:12:21ZShengjing Zhu
<ul></ul><p>Nathan Cutler wrote:</p>
<blockquote>
<p>@Shengjing Zhu: Thanks for the explanation. Opened a PR with a fix - please review.</p>
</blockquote>
<p>Thanks for your fix, after a quick look and grep locally,</p>
<p>in cmake/modules/Findrdma.cmake, it uses a different library name</p>
<p>./Findrdma.cmake:find_package_handle_standard_args(ibverbs DEFAULT_MSG RDMA_LIBRARIES RDMA_INCLUDE_DIR)</p>
<p>Maybe it's also a mistake</p> Ceph - Bug #19853: cmake modules should set proper package namehttps://tracker.ceph.com/issues/19853?journal_id=907402017-05-04T10:20:37ZKefu Chaitchaikov@gmail.com
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Resolved</i></li></ul>