Project

General

Profile

Bug #17898

tests: flake8 3.1.1 behavior changed

Added by Loic Dachary about 1 year ago. Updated 11 months ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
Start date:
11/14/2016
Due date:
% Done:

0%

Source:
Tags:
Backport:
jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Release:
Needs Doc:
No

Description

flake8 3.1.1 published a few hours ago does not behave the same and fails with:

flake8 runtests: commands[0] | flake8 --ignore=H105,H405,E127 ceph_disk tests
ceph_disk/main.py:173:1: E305 expected 2 blank lines after class or function definition, found 1
ceph_disk/main.py:5011:1: E305 expected 2 blank lines after class or function definition, found 1

on jewel and probably on master as well.


Related issues

Related to Ceph - Bug #17900: make check: run-tox-ceph-disk failure Duplicate 11/14/2016
Copied to Ceph - Backport #17903: jewel: tests: flake8 3.1.1 behavior changed Resolved

History

#1 Updated by Loic Dachary about 1 year ago

  • Backport set to jewel,hammer

#2 Updated by Ken Dreyer about 1 year ago

another approach, adding the whitespace in https://github.com/ceph/ceph/pull/11973

#3 Updated by Loic Dachary about 1 year ago

  • Status changed from Verified to Pending Backport
  • Backport changed from jewel,hammer to jewel

#4 Updated by Loic Dachary about 1 year ago

  • Copied to Backport #17903: jewel: tests: flake8 3.1.1 behavior changed added

#5 Updated by Ken Dreyer about 1 year ago

Discussed with Loic in IRC. We can revert the flake8 version pinning here, and re-address if further flake8 errors are found (with a couple other options).

#6 Updated by Nathan Cutler about 1 year ago

  • Duplicated by Bug #17900: make check: run-tox-ceph-disk failure added

#7 Updated by Nathan Cutler about 1 year ago

  • Duplicated by deleted (Bug #17900: make check: run-tox-ceph-disk failure)

#8 Updated by Nathan Cutler about 1 year ago

  • Related to Bug #17900: make check: run-tox-ceph-disk failure added

#9 Updated by Sage Weil about 1 year ago

  • Priority changed from Immediate to Urgent

#10 Updated by Nathan Cutler 11 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF