Project

General

Profile

Actions
Copy link

Bug #16421

closed

deep-scrub seems to update the omap digest on objects without any omap entries

Added by Samuel Just almost 8 years ago. Updated over 7 years ago.

Status:
Rejected
Priority:
Urgent
Assignee:
Samuel Just
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Strictly speaking, this is correct, but it's silly for deep-scrub to emit repops persisting the omap digest for an object with no omap entries.

Actions
Copy link
 #1

Updated by Sage Weil over 7 years ago

  • Priority changed from High to Urgent
Actions
Copy link
 #2

Updated by Greg Farnum over 7 years ago

I assume we have a separate field that indicates the omap count or something? Don't want to skip scrubbing because the primary has no omaps when the replicas do. ;)

Actions
Copy link
 #3

Updated by Samuel Just over 7 years ago

  • Status changed from New to In Progress
  • Assignee set to Samuel Just
Actions
Copy link
 #4

Updated by Samuel Just over 7 years ago

  • Status changed from In Progress to Rejected

I can't figure out why I thought this was true. I checked the code and it looks like object_info_t comes into the world with digests set to the seed, which would match an empty omap. I also grepped a few logs from recent runs and I don't see any evidence of extra digest updates. If someone remembers, reopen with more details!

Actions
Copy link

Also available in: Atom PDF