Project

General

Profile

Actions
Copy link

Bug #16327

closed

comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign)

Added by Nathan Cutler almost 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Nathan Cutler
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
jewel,hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

We are returning -ERR_NOT_MODIFIED but in rgw_rest_s3.cc the conditional omits the minus sign:

$ grep -r ERR_NOT_MODIFIED
src/rgw/rgw_common.h:#define ERR_NOT_MODIFIED         2016
src/rgw/rgw_rest_s3.cc:  if (op_ret == ERR_NOT_MODIFIED) {
src/rgw/rgw_rados.cc:  if (copy_if_newer && ret == -ERR_NOT_MODIFIED) {
src/rgw/rgw_rados.cc:        return -ERR_NOT_MODIFIED;
src/rgw/rgw_rados.cc:        return -ERR_NOT_MODIFIED;
src/rgw/rgw_http_errors.h:    { ERR_NOT_MODIFIED, 304, "NotModified" },
src/rgw/rgw_http_errors.h:      return -ERR_NOT_MODIFIED;

Related issues 2 (0 open — 2 closed)

Copied to rgw - Backport #16381: jewel: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign)ResolvedNathan CutlerActions
Copied to rgw - Backport #16382: hammer: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign)ResolvedWei-Chung ChengActions
Actions
Copy link

Also available in: Atom PDF