Project

General

Profile

Bug #16079

Enable/Disable of features is allowed even the features are already enabled/disabled

Added by Tanay Ganguly 10 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
05/31/2016
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Release:
jewel
Needs Doc:
No

Description

Description of problem:
If the feature is already enabled, still it allow user to enable it again.
Similarly goes with disable

Version-Release number of selected component (if applicable):
ceph version 10.2.1-6.el7cp

How reproducible:
Always.

Steps to Reproduce:
1.rbd info cephfs_data/img1

rbd image 'img1':
size 102400 MB in 25600 objects
order 22 (4096 kB objects)
block_name_prefix: rbd_data.1251ee238e1f29
format: 2
features: layering, deep-flatten
flags:

2. rbd feature disable cephfs_data/img1 exclusive-lock, object-map, fast-diff
3. rbd feature disable cephfs_data/img1 exclusive-lock, object-map, fast-diff
4. rbd feature disable cephfs_data/img1 exclusive-lock, object-map, fast-diff

Actual results:
User should not be allowed to disable the feature's which are not at all enabled.

Expected results:
There should be error saying that features are not enabled.

Additional info:
Same thing applies for enable.

We can enable multiple times the same features, even though its already enabled.


Related issues

Copied to Backport #17482: jewel: Enable/Disable of features is allowed even the features are already enabled/disabled Resolved

History

#1 Updated by lu shi 10 months ago

I have alreadr midified by the pull request below
https://github.com/ceph/ceph/pull/9451

#2 Updated by Jason Dillaman 10 months ago

  • Status changed from New to Need Review
  • Backport set to jewel

#3 Updated by Mykola Golub 6 months ago

  • Status changed from Need Review to Pending Backport
  • Needs Doc set to No

#4 Updated by Loic Dachary 6 months ago

  • Copied to Backport #17482: jewel: Enable/Disable of features is allowed even the features are already enabled/disabled added

#5 Updated by Loic Dachary 5 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF