Actions
Bug #14753
closedlokdep: uses lock name as the lock identity
Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
This is problematic if having multiple lock instances that share the same name.
Updated by Greg Farnum about 8 years ago
I don't think we want to change this by default. Locks that share the same name almost always have to follow the same locking rules. There are exceptions but there are workarounds for them, and not providing a shared identity for locks dramatically reduces the probability we can spot errors in lock ordering. This was important during the fast dispatch work, for instance.
If you have locks of the same class that need to grab each other, just make them unique by incorporating their address into the name or something.
Actions