Project

General

Profile

Actions
Copy link

Bug #13966

closed

memory leak in PG/replica_scrub

Added by Jie Wang over 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

PG::replica_scrub

if (last_update_applied < msg->scrub_to) {
    dout(10) << "waiting for last_update_applied to catch up" << dendl;
    scrubber.active_rep_scrub = op;
    msg>get();-
    return;
  }

this increases reference count of msg and causes memory leak

Actions
Copy link
 #1

Updated by Samuel Just over 8 years ago

  • Backport set to hammer

Fixed in 5b35eb8d27ea7bb3aee6d14ad2eaed5f42c1adb0. Should be backported to hammer.

Actions
Copy link
 #2

Updated by Nathan Cutler about 8 years ago

  • Status changed from New to Pending Backport
Actions
Copy link
 #4

Updated by Loïc Dachary about 8 years ago

Sam : back in hammer the code was like that:

    scrubber.active_rep_scrub = msg;
    msg->get();

in infernalis it became

    scrubber.active_rep_scrub = op;
    msg->get();

which leaks msg. I think the leak did not exist in hammer.

Actions
Copy link
 #5

Updated by Loïc Dachary about 8 years ago

  • Status changed from Pending Backport to Resolved
  • Backport deleted (hammer)
Actions
Copy link

Also available in: Atom PDF