Project

General

Profile

Bug #13554

make dist fails with : rocksdb/tools/rdb/rdb.cc v8.h: No such file or directory

Added by Loic Dachary almost 3 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
Start date:
10/21/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:

Description

make dist after make check occasionally (once every 20 runs or so) fails with the following (see http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/8526/console for an example)

make  dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory `/home/jenkins/workspace/ceph/LABELS/ceph-centos-7-jenkins'
if test -d "ceph-9.1.0"; then find "ceph-9.1.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "ceph-9.1.0" || { sleep 5 && rm -rf "ceph-9.1.0"; }; else :; fi
test -d "ceph-9.1.0" || mkdir "ceph-9.1.0" 
 (cd src && make  top_distdir=../ceph-9.1.0 distdir=../ceph-9.1.0/src \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/workspace/ceph/LABELS/ceph-centos-7-jenkins/src'
./make_version -g ./.git_version
if [ -n "$NO_VERSION" ] ; then \
    ./make_version -g ./.git_version -c ./ceph_ver.h -n ; \
else \
    ./make_version -g ./.git_version -c ./ceph_ver.h ; \
fi
ccache g++ -Wall -g -std=gnu++11    rocksdb/tools/rdb/rdb.cc   -o rocksdb/tools/rdb/rdb
rocksdb/tools/rdb/rdb.cc:5:16: fatal error: v8.h: No such file or directory
 #include <v8.h>
                ^
compilation terminated.
make[2]: *** [rocksdb/tools/rdb/rdb] Error 1
make[2]: Leaving directory `/home/jenkins/workspace/ceph/LABELS/ceph-centos-7-jenkins/src'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory `/home/jenkins/workspace/ceph/LABELS/ceph-centos-7-jenkins'
make: *** [dist] Error 2

Associated revisions

Revision dd31d4a0 (diff)
Added by Kefu Chai almost 3 years ago

rocksdb: remove rdb source files from dist tarball

rdb is based on NodeJS, and we don't build rdb to use rocksdb as
a keyvaluestore backend.

Fixes: #13554
Signed-off-by: Kefu Chai <>

Revision 392f784d (diff)
Added by Venky Shankar over 2 years ago

rocksdb: remove rdb sources from dist tarball

Fixes: #13554
Signed-off-by: Venky Shankar <>

History

#4 Updated by Loic Dachary almost 3 years ago

  rocksdb/tools/rdb/rdb \
  rocksdb/tools/rdb/rdb.cc \

it tries to compile rocksdb/tools/rdb/rdb with rocksdb/tools/rdb/rdb.cc and fails.

#5 Updated by Loic Dachary almost 3 years ago

  • Status changed from Verified to Resolved
  • Assignee set to Kefu Chai

#6 Updated by Kefu Chai over 2 years ago

per the analysis of Loïc,

if the timestamp of rbd is older than that of rbd.cc, "make dist" will follow the implicit rule, and try to compile rbd.cc. but rbd.cc needs NodeJS to compile.

#7 Updated by Kefu Chai over 2 years ago

  • Status changed from Resolved to Verified

aa844e58 reverts the fix.

#8 Updated by Venky Shankar over 2 years ago

https://github.com/ceph/ceph/pull/7105

With the above patch "make dist" runs successfully.

#9 Updated by Kefu Chai over 2 years ago

  • Status changed from Verified to Resolved

#10 Updated by Kefu Chai about 2 years ago

  • Status changed from Resolved to Need Review

#11 Updated by Kefu Chai about 2 years ago

  • Status changed from Need Review to Resolved

Also available in: Atom PDF