Project

General

Profile

Bug #12662

ThreadPool add/remove work queue methods not thread safe

Added by Jason Dillaman over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
-
Start date:
08/10/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
hammer,firefly
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

librbd uses a singleton ThreadPool for asynchronous operations for each image. As images are opened and closed, WorkQueues are added/removed from the singleton ThreadPool. Since this operation isn't protected, this occasionally results in a crash of the librbd unit tests.


Related issues

Copied to Ceph - Backport #13042: ThreadPool add/remove work queue methods not thread safe Resolved
Copied to Ceph - Backport #13043: ThreadPool add/remove work queue methods not thread safe Resolved 08/10/2015

Associated revisions

Revision 3e18449b (diff)
Added by Jason Dillaman over 3 years ago

WorkQueue: add/remove_work_queue methods now thread safe

These methods were not acquiring the ThreadPool lock when
manipulating the work_queue collection. This was causing
occasional crashes within librbd when opening and closing
images.

Fixes: #12662
Backport: hammer, firefly
Signed-off-by: Jason Dillaman <>

Revision d8ac5103 (diff)
Added by Jason Dillaman about 3 years ago

WorkQueue: add/remove_work_queue methods now thread safe

These methods were not acquiring the ThreadPool lock when
manipulating the work_queue collection. This was causing
occasional crashes within librbd when opening and closing
images.

Fixes: #12662
Backport: hammer, firefly
Signed-off-by: Jason Dillaman <>
(cherry picked from commit 3e18449b01c1ab78d1bbfc1cf111aa9bdbef7b1f)

Revision 8c14cad0 (diff)
Added by Jason Dillaman about 3 years ago

WorkQueue: add/remove_work_queue methods now thread safe

These methods were not acquiring the ThreadPool lock when
manipulating the work_queue collection. This was causing
occasional crashes within librbd when opening and closing
images.

Fixes: #12662
Backport: hammer, firefly
Signed-off-by: Jason Dillaman <>
(cherry picked from commit 3e18449b01c1ab78d1bbfc1cf111aa9bdbef7b1f)

History

#1 Updated by Jason Dillaman over 3 years ago

  • Backport set to hammer,firefly

#2 Updated by Jason Dillaman over 3 years ago

  • Status changed from New to In Progress

#3 Updated by Jason Dillaman over 3 years ago

  • Status changed from In Progress to Need Review

#4 Updated by Kefu Chai about 3 years ago

  • Status changed from Need Review to Pending Backport

#5 Updated by Loic Dachary about 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF