Actions
Feature #12106
openCInodes encoded unversioned in dirfrags
Status:
New
Priority:
Normal
Assignee:
-
Category:
Code Hygiene
Target version:
-
% Done:
0%
Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Description
Where we encode CInodes in the omap values of a dirfrag, we do it without any ENCODE_START decorators (InodeStoreBase::encode_bare).
This results in wonky decoding logic where we're reading til the end of the buffer instead of reading fields expected for a particular version. Just about works for fixed size fields, but is undesirable. We should take the small overhead of encoding version headers in each inode.
Updated by Greg Farnum almost 8 years ago
- Category changed from 47 to Code Hygiene
- Component(FS) MDS added
Actions