Project

General

Profile

Bug #11786

mon: MonitorDBStore iterator's get_next_key() returns wrong keys

Added by Joao Luis over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
Monitor
Target version:
-
Start date:
05/27/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
firefly, hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

specifically, the first key of the iterator is always returned first, regardless of it's prefix being passed on to the iterator's prefixes.

Fix incoming.


Related issues

Copied to Ceph - Backport #12483: mon: MonitorDBStore iterator's get_next_key() returns wrong keys Resolved
Copied to Ceph - Backport #12484: mon: MonitorDBStore iterator's get_next_key() returns wrong keys Resolved 05/27/2015

Associated revisions

Revision 2cc7aee1 (diff)
Added by Joao Luis over 3 years ago

mon: MonitorDBStore: get_next_key() only if prefix matches

get_next_key() had a bug in which we would always return the first key
from the iterator, regardless of whether its prefix had been specified
to the iterator.

Fixes: #11786

Signed-off-by: Joao Eduardo Luis <>

Revision e6eaa914 (diff)
Added by Joao Luis over 3 years ago

mon: MonitorDBStore: get_next_key() only if prefix matches

get_next_key() had a bug in which we would always return the first key
from the iterator, regardless of whether its prefix had been specified
to the iterator.

Fixes: #11786

Signed-off-by: Joao Eduardo Luis <>
(cherry picked from commit 2cc7aee1abe40453093306c8fef2312b650dff5d)

Revision d5218701 (diff)
Added by Joao Luis over 3 years ago

mon: MonitorDBStore: get_next_key() only if prefix matches

get_next_key() had a bug in which we would always return the first key
from the iterator, regardless of whether its prefix had been specified
to the iterator.

Fixes: #11786

Signed-off-by: Joao Eduardo Luis <>
(cherry picked from commit 2cc7aee1abe40453093306c8fef2312b650dff5d)

History

#1 Updated by Joao Luis over 3 years ago

  • Status changed from Verified to Need Review

#2 Updated by Joao Luis over 3 years ago

  • Status changed from Need Review to Pending Backport

need to check how far back we need to backport this.

#3 Updated by Joao Luis over 3 years ago

  • Backport set to firefly, hammer

commit to cherry-pick is 2cc7aee1abe40453093306c8fef2312b650dff5d

cherry-pick is trivial.

wip-11786.firefly has firefly backport (https://github.com/ceph/ceph/pull/5360)
wip-11786.hammer has hammer backport (https://github.com/ceph/ceph/pull/5361)

#4 Updated by Loic Dachary about 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF