Project

General

Profile

Actions
Copy link

Bug #11505

closed

"Invalid argument: osd_disk_thread_ioprio_class" while set to ""

Added by Wido den Hollander almost 9 years ago. Updated about 7 years ago.

Status:
Won't Fix
Priority:
Normal
Assignee:
-
Category:
OSD
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
v0.94
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I just noticed when starting a 0.94.1 (Hammer) OSD that it logged:

2015-04-29 14:02:37.015454 7f887875e900 -1 osd.456 43089 set_disk_tp_priority(22) Invalid argument: osd_disk_thread_ioprio_class is  but only the following values are allowed: idle, be or rt

The default config is:

OPTION(osd_disk_thread_ioprio_class, OPT_STR, "") // rt realtime be best effort idle

In the code this is checked (OSD.cc):

_conf->osd_disk_thread_ioprio_class.empty() ||
       cct->_conf->osd_disk_thread_ioprio_priority < 0)
     return;

Although .empty() returns True in my tests when a string is "", it doesn't seem to do that here.

Actions
Copy link
 #1

Updated by Sage Weil almost 9 years ago

  • Assignee set to Loïc Dachary
  • Regression set to No

i thought this was fixed a while back?

Actions
Copy link
 #2

Updated by Loïc Dachary almost 9 years ago

  • Status changed from New to In Progress

I don't remember this corner case was fixed. I'll take a look.

Actions
Copy link
 #3

Updated by Loïc Dachary over 8 years ago

  • Assignee deleted (Loïc Dachary)
Actions
Copy link
 #4

Updated by Sage Weil about 7 years ago

  • Status changed from In Progress to Won't Fix
Actions
Copy link

Also available in: Atom PDF