Project

General

Profile

Actions

Bug #11493

closed

mon: adding exsting pool as tier with --force-nonempty clobbers removed_snaps

Added by Sage Weil almost 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
firefly,hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

1. images had snapshots (and removed_snaps)

2. images was added as a tier of img, and img's removed_snaps was copied
to images, clobbering the removed_snaps value (see
OSDMap::Incremental::propagate_snaps_to_tiers)

3. tiering relation was undone, but removed_snaps was still gone

4. on OSD startup, when we load the PG, removed_snaps is initialized with
the older map. later, in PGPool::update(), we assume that removed_snaps
alwasy grows (never shrinks) and we trigger an assert.

To fix this I think we need to do 2 things:

1. make the OSD forgiving out removed_snaps getting smaller. This is
probably a good thing anyway: once we know snaps are removed on all OSDs
we can prune the interval_set in the OSDMap. Maybe.

2. Fix the mon to prevent this from happening, even when
--force-nonempty is specified. (This is the root cause.)


Related issues 3 (0 open3 closed)

Related to Ceph - Bug #7915: ./include/interval_set.h: 385: FAILED assert(_size >= 0)Duplicate03/31/2014

Actions
Copied to Ceph - Backport #12312: mon: adding exsting pool as tier with --force-nonempty clobbers removed_snapsResolvedSage Weil04/28/2015Actions
Copied to Ceph - Backport #12314: mon: adding exsting pool as tier with --force-nonempty clobbers removed_snapsResolvedSage Weil04/28/2015Actions
Actions #1

Updated by Sage Weil almost 9 years ago

  • Description updated (diff)
Actions #2

Updated by Sage Weil almost 9 years ago

  • Status changed from New to Fix Under Review
Actions #3

Updated by Samuel Just almost 9 years ago

  • Status changed from Fix Under Review to Resolved
  • Regression set to No
Actions #4

Updated by Nathan Cutler almost 9 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to firefly,hammer
Actions #6

Updated by Loïc Dachary over 8 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF