Actions
Bug #11065
closedimplement tox tests for ceph-disk
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
- to verify python2 / python3 syntax
- minimal unittesting
The suggestion for minimal unit testing is because src/test/ceph-disk.sh has integration tests. Since ceph-disk desired side effects require an integration environment for the most part, actual unit testing would require a lot of mocking which is both prone to error and tedious to maintain.
Updated by Alfredo Deza about 9 years ago
Enforcing unit tests for new helpers and small functions will actually make it less error prone, ensure reliable changes and will not require mocking of any sort.
I will get the initial structure with a few tests so that we can get started and start enforcing tests with new changes.
Updated by Alfredo Deza about 9 years ago
- Status changed from 12 to Fix Under Review
Pull request opened https://github.com/ceph/ceph/pull/4179
Updated by Alfredo Deza about 9 years ago
- Status changed from Fix Under Review to Resolved
merged commit dc85cb9 into master
Actions