Project

General

Profile

Bug #10546

ceph time check start round bug in monitor.cc

Added by eyun xu almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Monitor
Target version:
-
Start date:
01/14/2015
Due date:
% Done:

0%

Source:
Community (user)
Tags:
Backport:
giant,firefly
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

HI all,

My ceph cluster report clock skew even after time syncing 30min ago, so i'm digging in the src code of ceph0.80.6,
i think the following code in void Monitor::timecheck_start_round() in monitor.cc from line 3160 to 3168 is very strange,

in my opinion, the highligted part should be curr_time - timecheck_round_start < max ,

that is: if time elapsed less than max, then keep current round going, else cancel current round.

double max = g_conf->mon_timecheck_interval*3;
if (curr_time - timecheck_round_start > max) {
dout(10) << func << " keep current round going" << dendl;
goto out;
} else {
dout(10) << func
<< " finish current timecheck and start new" << dendl;
timecheck_cancel_round();
}

just my opinion, any reply is welcomed!

thanks very much

Associated revisions

Revision 2e749599 (diff)
Added by Joao Eduardo Luis over 3 years ago

mon: Monitor: fix timecheck rounds period

Fixes: #10546
Backports: dumpling?,firefly,giant

Signed-off-by: Joao Eduardo Luis <>

Revision 368a5a8a (diff)
Added by Joao Eduardo Luis over 3 years ago

mon: Monitor: fix timecheck rounds period

Fixes: #10546
Backports: dumpling?,firefly,giant

Signed-off-by: Joao Eduardo Luis <>
(cherry picked from commit 2e749599ac6e1060cf553b521761a93fafbf65bb)

Revision fe7d4ca1 (diff)
Added by Joao Eduardo Luis over 3 years ago

mon: Monitor: fix timecheck rounds period

Fixes: #10546
Backports: dumpling?,firefly,giant

Signed-off-by: Joao Eduardo Luis <>
(cherry picked from commit 2e749599ac6e1060cf553b521761a93fafbf65bb)

History

#1 Updated by Sage Weil almost 4 years ago

  • Assignee set to Joao Luis
  • Source changed from other to Community (user)

#2 Updated by Joao Luis almost 4 years ago

  • Category set to Monitor
  • Status changed from New to Need Review

#3 Updated by Sage Weil over 3 years ago

  • Status changed from Need Review to Pending Backport
  • Backport set to giant,firefly

#4 Updated by Loic Dachary over 3 years ago

  • Severity changed from 1 - critical to 3 - minor

#5 Updated by Loic Dachary over 3 years ago

  • Description updated (diff)

#8 Updated by Sage Weil over 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF