Project

General

Profile

Actions
Copy link

Tasks #10518

closed

radosgw-agent: catch master up with v1.2?

Added by Ken Dreyer over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Josh Durgin
Target version:
-
% Done:

0%

Tags:
Reviewed:
Affected Versions:
Pull request ID:

Description

There is a "v1.2" branch in https://github.com/ceph/radosgw-agent/tree/v1.2 , but not all the changes have been merged back into master.

I found this because I noticed the radosgw-agent.spec file still contains a version number of "1.1". The reason I'm looking at this is because I'm looking at packaging radosgw-agent downstream (in Fedora and in Red Hat Ceph).

Here's a link that shows the commits in v1.2 that have not yet been merged to master: https://github.com/ceph/radosgw-agent/compare/v1.2

Was this simply an oversight, or is something else going on?

Actions
Copy link
 #1

Updated by Ken Dreyer over 9 years ago

  • Status changed from New to Fix Under Review

After discussing in #ceph-devel, the following PR will resolve this : https://github.com/ceph/radosgw-agent/pull/16

Actions
Copy link
 #2

Updated by Ken Dreyer over 9 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #3

Updated by Ken Dreyer about 9 years ago

After some discussion in IRC today, Alfredo and I decided to delete the v1.2 branch from GitHub entirely. (For posterity, the refs/heads/v1.2 pointed at 6978983587fb37b79d93c64faaf6bdcd8e7079be).

The 1.2 RPM at http://ceph.com/rpm/el7/noarch/ was built from refs/heads/v1.2, but users should not use that - they should use the 1.2 version from PyPI, since that's the canonical v1.2 that's tagged in GitHub, and it's the same v1.2 to which radosgw-agent's CHANGELOG.rst file refers.

We'll get this right when it comes time for v1.3.

Actions
Copy link

Also available in: Atom PDF