Bug #57890
Updated by Radoslaw Zarzynski over 1 year ago
In https://github.com/ceph/ceph/pull/23557 we switched @cmd_getval()@ to throw on error. This family of functions have around 500 of users while only few were fitted with @try {} catch@ as – possibly – even an unhandled exception can be deemed a lesser evil than a byzantine fault (due to letting a program to execute further after ignoring an error). However, recently https://tracker.ceph.com/issues/54558 popped up and ignited the discussion (see https://github.com/ceph/ceph/pull/45547#pullrequestreview-1099607585). which has bred https://tracker.ceph.com/issues/54558. See https://github.com/ceph/ceph/pull/45547#pullrequestreview-1099607585.
Could we tackle the problem handle it by switching back to error codes while using @[[nodiscard]]@ to hunt down all callers who ignore the errors? codes/rets and @[[nodiscard]]@?