Bug #9944: objecter: pool dne checks not correct - Ceph - Ceph

Actions

Copy link

Bug #9944

closed

objecter: pool dne checks not correct

Added by Sage Weil over 9 years ago. Updated almost 9 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Josh Durgin

Category:

Objecter

Target version:

% Done:

Source:

Development

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

> 
> _____________________________________________________________________________$
> *** CID 1250262:  Dereference after null check  (FORWARD_NULL)
> /osdc/Objecter.cc: 2062 in Objecter::_calc_target(Objecter::op_target_t *, bo$
> 2056         if (ret == -ENOENT) {
> 2057           t->osd = -1;
> 2058           return RECALC_OP_TARGET_POOL_DNE;
> 2059         }
> 2060       }  
> 2061
> >>>     CID 1250262:  Dereference after null check  (FORWARD_NULL)
> >>>     Dereferencing null pointer "pi".
> 2062       int min_size = pi->min_size; 
> 2063       unsigned pg_num = pi->get_pg_num();
> 2064       int up_primary, acting_primary;
> 2065       vector<int> up, acting;
> 2066       osdmap->pg_to_up_acting_osds(pgid, &up, &up_primary,
> 2067                                 &acting, &acting_primary);