Project

General

Profile

Feature #9526

mon: 'osd crush rename-bucket <old> <new>'

Added by Sage Weil over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Loïc Dachary
Category:
OSD
Target version:
0.89
% Done:

100%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Associated revisions

Revision aa675604 (diff)
Added by Loic Dachary over 8 years ago

mon: add the osd crush rename-bucket command

The synopsis is:

osd crush rename-bucket name1 name2

It is made idempotent by interpreting -EALREADY as returned by
CrushWrapper::rename_bucket return as success.

The crush_rename_bucket method first checks for errors with
CrushWrapper::can_rename_bucket if there is no pending crush so that it
can return early and avoid the creation of a pending crush map.

If renaming is possible, CrushWrapper::rename_bucket is called on the
pending crush map (and creates it indirectly if it does not already
exists).

http://tracker.ceph.com/issues/9526 Fixes: #9526

Signed-off-by: Loic Dachary <>

History

#1 Updated by Loïc Dachary over 8 years ago

  • Tracker changed from Bug to Feature

#2 Updated by Ian Colle over 8 years ago

  • Assignee set to Loïc Dachary

#3 Updated by Samuel Just over 8 years ago

  • Target version changed from 0.88 to 0.89

#4 Updated by Loïc Dachary over 8 years ago

  • Status changed from New to In Progress
<loicd> sage: is there a reason to restrict osd crush rename to buckets ? It seems equally simple to implement it to rename bucket or items.  http://tracker.ceph.com/issues/9526
<sage> we semi-enforce that items are osd.NNN
<sage> i worry that allowing anything else will introduce ambiguity (what if i rename osd.2 to osd.4?)
<loicd> ok

#5 Updated by Loïc Dachary over 8 years ago

  • Status changed from In Progress to Fix Under Review
  • % Done changed from 0 to 80

#6 Updated by Loïc Dachary over 8 years ago

  • Category set to OSD
  • Status changed from Fix Under Review to Resolved
  • % Done changed from 80 to 100

Also available in: Atom PDF