Fix #8712
closed
Teuthology-lock should not lock if the downburst failed
Added by Anonymous almost 10 years ago.
Updated over 9 years ago.
Description
Teuthology-lock --lock-many 1 --machine-type vps --os-type aardvark --os-version vampirebat successfully locks a machine, but the downburst create failed (Image not found). The lock should definitely not happen, and an appropriate error message other than the downburst dump should be displayed.
- Assignee set to Anonymous
The following cases all end up locking a vps machine that is improperly downbursted:
teuthology-lock --lock-many 1 --machine-type vps --os-type aardvark
teuthology-lock --lock-many 1 --machine-type vps --os-type aardvark --os-version vampirebat
teuthology-lock --lock-many 1 --machine-type vps --os-type rhel --os-version vampirebat
teuthology-lock --lock-many 1 --machine-type vps --os-version vampirebat
The last 3 examples lock a machine and say that they lock a machine, the first example throws a KeyError exception and still locks a machine.
I am sending in a pull request that displays error messages and does not lock a machine in the above examples.
- Status changed from New to In Progress
- Status changed from In Progress to Fix Under Review
- Tracker changed from Bug to Fix
- Target version set to sprint11
Warren, what's the status of this?
The last review suggest some changes. I will resubmit today.
New changes have been pushed to https://github.com/ceph/teuthology/pull/297
The changes are failing jenkins testing. I believe that this is because the unit tests that
I have added are failing because the downburst changes in wip-8925-wusui are not yet checked in.
- Target version changed from sprint11 to sprint13
Urgh. I have implemented this change to be able to handle checking without downburst (using the downburst data if it's available). To test, I removed the local downburst executable ('which downburst' now shows nothing), and tried to create a vm system. This failed in another part of teuthology/lock.py which tried to start with a fresh vm using downburst. How does this ever work normally when downburst is not installed? I suspect it does not, in which case my checking to make sure vm parameters are valid is moot because this code would never work in the first place.
Excuse me while I go chase a squirrel.
Why are there teeth marks on my tail?
- Assignee changed from Anonymous to Zack Cerza
- Status changed from Fix Under Review to Resolved
Fixed in commit 6f5296d40c8fd73b3cbb7db2875289ddbeebf0bd
Also available in: Atom
PDF