Project

General

Profile

Bug #7065

omap_clear() also removes all of object's xatts

Added by Zheng Yan almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
OSD
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Related issues

Related to Ceph - Bug #7071: osd/ReplicatedPG.cc: 5953: FAILED assert(attrs->count("_")) Resolved 12/30/2013

Associated revisions

Revision 0c81849c (diff)
Added by Samuel Just over 9 years ago

os/DBObjectMap, FileStore: omap_clear should not remove xattrs

Prevously, FileStore::_omap_clear() used ObjectMap::clear(), which
incorrectly also blasts any stored xattrs. Instead, add
ObjectMap::clear_keys_header() to handle this case efficiently.

Fixes: #7065
Fixes: #7135
Signed-off-by: Samuel Just <>

History

#1 Updated by Haomai Wang almost 10 years ago

It's amazing that just notice it now.

I think it's a little related to feature(http://tracker.ceph.com/issues/7059). Maybe DBObjectMap need to introduce two new interface "clear_xattr",and "clear_omap".

#2 Updated by Sage Weil almost 10 years ago

I think we should update test/osd/RadosModel (ceph_test_rados) so that it stores separate data in xattrs and omap (right now it mirrors the content).. so that it notices this.

#3 Updated by Samuel Just over 9 years ago

  • Status changed from New to Resolved

0c81849c4f1661ce89b8623edaf2873bb6611f62

Also available in: Atom PDF