Cleanup #660: mds: use helpers in mknod, mkdir, openc paths - CephFS - Ceph

Actions

Copy link

Cleanup #660

closed

mds: use helpers in mknod, mkdir, openc paths

Added by Sage Weil over 13 years ago. Updated over 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Code Hygiene

Target version:

% Done:

Tags:

Backport:

Reviewed:

Affected Versions:

Component(FS):

Labels (FS):

Pull request ID:

Description

Lots of not-quite-duplicate code here that can be cleaned up

Actions

Copy link

Updated by Sage Weil about 13 years ago

Target version changed from v0.25 to 19

Actions

Copy link

Updated by Sage Weil about 13 years ago

Translation missing: en.field_position set to 383

Actions

Copy link

Updated by Sage Weil over 12 years ago

Target version deleted (19)

Actions

Copy link

Updated by Sage Weil over 11 years ago

Project changed from Ceph to CephFS
Category deleted (1)

Actions

Copy link

Updated by Sage Weil over 11 years ago

Translation missing: en.field_position deleted (~~1001~~)
Translation missing: en.field_position set to 3

Actions

Copy link

Updated by Greg Farnum over 11 years ago

What kind of helpers are you talking about with this? inode fetchers and lock grabbers? In a quick scan over handle_client_mknod and handle_client_mkdir I don't see anything larger than about 3 lines that's the same, and the interface handling to make function calls around that would be about 3 lines on its own...

Actions

Copy link