Project

General

Profile

Actions

Bug #65531

open

crimson-osd: dump_historic_slow_ops command not correctly run

Added by junxiang mu 14 days ago. Updated 9 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

right now, historic ops and historic slow ops all placed in OperationTypeCode::historic_client_request op_list, use last_of_recents iter mark division line;
there have some problem:
1. because op_list is not a sorted list, so dump_historic_slow_ops command will show all the historic client_request, just sorted by op duration;
2. OSDOperationRegistry::num_slow_ops not really represent slow ops number, it always equal local_conf()->osd_op_history_slow_op_size(20 default) when total op number greater than 40;
3. dump_historic_slow_ops or dump_historic_ops will output (local_conf()->osd_op_history_op_size + local_conf()->osd_op_history_slow_op_size) ops;

I will try fix this

Actions #1

Updated by junxiang mu 14 days ago

I don't think it's necessary to put history_cliend_request and history_slow_cliend_request together, so I will separate them

Actions #3

Updated by Matan Breizman 9 days ago

  • Status changed from New to In Progress
  • Assignee set to junxiang mu
Actions

Also available in: Atom PDF