Project

General

Profile

Actions

Tasks #65471

open

rgw_sal_posix.cc printf compiler warnings

Added by Casey Bodley 20 days ago. Updated 17 days ago.

Status:
Fix Under Review
Priority:
Normal
Target version:
-
% Done:

0%

Tags:
posix
Reviewed:
Affected Versions:
Pull request ID:

Description

src/rgw/driver/posix/rgw_sal_posix.cc: In member function 'rgw::sal::POSIXObject::generate_mp_etag(DoutPrefixProvider const*, optional_yield)':
src/rgw/driver/posix/rgw_sal_posix.cc:2246:14: warning: '%lld' directive output may be truncated writing between 1 and 19 bytes into a region of size 15 [-Wformat-truncation=]
 2246 |            "-%lld", (long long)count);
      |              ^~~~
/build/ceph-19.0.0-2281-ga2104e0c/src/rgw/driver/posix/rgw_sal_posix.cc:2246:12: note: directive argument in the range [0, 9223372036854775807]
 2246 |            "-%lld", (long long)count);
      |            ^~~~~~~
/build/ceph-19.0.0-2281-ga2104e0c/src/rgw/driver/posix/rgw_sal_posix.cc:2244:11: note: 'snprintf' output between 3 and 21 bytes into a destination of size 16
 2244 |   snprintf(&final_etag_str[CEPH_CRYPTO_MD5_DIGESTSIZE * 2],
      |   ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2245 |            sizeof(final_etag_str) - CEPH_CRYPTO_MD5_DIGESTSIZE * 2,
      |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2246 |            "-%lld", (long long)count);
      |            ~~~~~~~~~~~~~~~~~~~~~~~~~~
Actions #1

Updated by Daniel Gryniewicz 17 days ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 56906
Actions

Also available in: Atom PDF