Bug #65183
openOverriding an EC pool needs the "--yes-i-really-mean-it" flag in addition to "force"
0%
Description
/a/yuriw-2024-03-26_14:32:05-rados-wip-yuri8-testing-2024-03-25-1419-distro-default-smithi/7623454
2024-03-26T20:13:29.028 INFO:tasks.workunit.client.0.smithi110.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/cephtool/test.sh:35: expect_false: set -x
2024-03-26T20:13:29.028 INFO:tasks.workunit.client.0.smithi110.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/cephtool/test.sh:36: expect_false: ceph osd erasure-code-profile set fooprofile a=b c=d e=f
2024-03-26T20:13:29.301 INFO:tasks.workunit.client.0.smithi110.stderr:Error EPERM: will not override erasure code profile fooprofile because the existing profile {a=b,c=d,crush-device-class=,crush-failure-domain=osd,crush-num-failure-domains=0,crush-osds-per-failure-domain=0,crush-root=default,jerasure-per-chunk-alignment=false,k=2,m=1,plugin=jerasure,technique=reed_sol_van,w=8} is different from the proposed profile {a=b,c=d,crush-device-class=,crush-failure-domain=osd,crush-num-failure-domains=0,crush-osds-per-failure-domain=0,crush-root=default,e=f,jerasure-per-chunk-alignment=false,k=2,m=1,plugin=jerasure,technique=reed_sol_van,w=8}
2024-03-26T20:13:29.304 INFO:tasks.workunit.client.0.smithi110.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/cephtool/test.sh:36: expect_false: return 0
2024-03-26T20:13:29.304 INFO:tasks.workunit.client.0.smithi110.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/cephtool/test.sh:2493: test_mon_osd_erasure_code: ceph osd erasure-code-profile set fooprofile a=b c=d e=f --force
2024-03-26T20:13:29.581 INFO:tasks.workunit.client.0.smithi110.stderr:Error EPERM: overriding erasure code profile can be DANGEROUS; add --yes-i-really-mean-it to do it anyway
2024-03-26T20:13:29.585 INFO:tasks.workunit.client.0.smithi110.stderr:/home/ubuntu/cephtest/clone.client.0/qa/workunits/cephtool/test.sh:1: test_mon_osd_erasure_code: rm -fr /tmp/cephtool.wZw
2024-03-26T20:13:29.586 DEBUG:teuthology.orchestra.run:got remote process result: 1
2024-03-26T20:13:29.587 INFO:tasks.workunit:Stopping ['cephtool'] on client.0...
Here's the test that fails:
qa/workunits/cephtool/test.sh
function test_mon_osd_erasure_code()
{
ceph osd erasure-code-profile set fooprofile a=b c=d
ceph osd erasure-code-profile set fooprofile a=b c=d
expect_false ceph osd erasure-code-profile set fooprofile a=b c=d e=f
ceph osd erasure-code-profile set fooprofile a=b c=d e=f --force ---------------------> this one
ceph osd erasure-code-profile set fooprofile a=b c=d e=f
expect_false ceph osd erasure-code-profile set fooprofile a=b c=d e=f g=h
# make sure rule-foo doesn't work anymore
expect_false ceph osd erasure-code-profile set barprofile ruleset-failure-domain=host
ceph osd erasure-code-profile set barprofile crush-failure-domain=host
# clean up
ceph osd erasure-code-profile rm fooprofile
ceph osd erasure-code-profile rm barprofile
# try weird k and m values
expect_false ceph osd erasure-code-profile set badk k=1 m=1
expect_false ceph osd erasure-code-profile set badk k=1 m=2
expect_false ceph osd erasure-code-profile set badk k=0 m=2
expect_false ceph osd erasure-code-profile set badk k=-1 m=2
expect_false ceph osd erasure-code-profile set badm k=2 m=0
expect_false ceph osd erasure-code-profile set badm k=2 m=-1
ceph osd erasure-code-profile set good k=2 m=1
ceph osd erasure-code-profile rm good
}
Updated by Laura Flores about 1 month ago
Likely coming from this change:
https://github.com/ceph/ceph/pull/56287
Updated by Radoslaw Zarzynski about 1 month ago
- Status changed from New to Fix Under Review
- Assignee set to Radoslaw Zarzynski
- Pull request ID set to 56531
Updated by Laura Flores 25 days ago
Also needs to be fixed for qa/standalone/mon/osd-erasure-code-profile.sh:
/a/yuriw-2024-04-01_20:57:46-rados-wip-yuri3-testing-2024-04-01-0837-squid-distro-default-smithi/7634757
2024-04-02T04:26:16.310 INFO:tasks.workunit.client.0.smithi107.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/mon/osd-erasure-code-profile.sh:62: TEST_set: grep 'will not override' td/osd-erasure-code-profile/out
2024-04-02T04:26:16.311 INFO:tasks.workunit.client.0.smithi107.stdout:Error EPERM: will not override erasure code profile myprofile because the existing profile {crush-device-class=,crush-failure-domain=host,crush-num-failure-domains=0,crush-osds-per-failure-domain=0,crush-root=default,k=7,key=value,m=3,plugin=isa,technique=reed_sol_van} is different from the proposed profile {crush-device-class=,crush-failure-domain=host,crush-num-failure-domains=0,crush-osds-per-failure-domain=0,crush-root=default,jerasure-per-chunk-alignment=false,k=2,m=2,plugin=jerasure,technique=reed_sol_van,w=8}
2024-04-02T04:26:16.311 INFO:tasks.workunit.client.0.smithi107.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/mon/osd-erasure-code-profile.sh:63: TEST_set: ceph osd erasure-code-profile set myprofile key=other --force
2024-04-02T04:26:16.459 INFO:tasks.workunit.client.0.smithi107.stderr:Error EPERM: overriding erasure code profile can be DANGEROUS; add --yes-i-really-mean-it to do it anyway
2024-04-02T04:26:16.462 INFO:tasks.workunit.client.0.smithi107.stderr:/home/ubuntu/cephtest/clone.client.0/qa/standalone/mon/osd-erasure-code-profile.sh:63: TEST_set: return 1
Updated by Laura Flores 12 days ago ยท Edited
/a/yuriw-2024-04-09_01:16:20-rados-reef-release-distro-default-smithi/7647523
/a/yuriw-2024-04-09_01:16:20-rados-reef-release-distro-default-smithi/7647366
/a/yuriw-2024-04-09_01:16:20-rados-reef-release-distro-default-smithi/7647663
/a/yuriw-2024-04-09_01:16:20-rados-reef-release-distro-default-smithi/7647809
/a/yuriw-2024-04-09_01:16:20-rados-reef-release-distro-default-smithi/7647747
Updated by Matan Breizman 10 days ago
/a/yuriw-2024-04-16_23:25:35-rados-wip-yuriw-testing-20240416.150233-distro-default-smithi/7659300
/a/yuriw-2024-04-16_23:25:35-rados-wip-yuriw-testing-20240416.150233-distro-default-smithi/7659372
/a/yuriw-2024-04-16_23:25:35-rados-wip-yuriw-testing-20240416.150233-distro-default-smithi/7659443
/a/yuriw-2024-04-16_23:25:35-rados-wip-yuriw-testing-20240416.150233-distro-default-smithi/7659482
/a/yuriw-2024-04-16_23:25:35-rados-wip-yuriw-testing-20240416.150233-distro-default-smithi/7659512