Project

General

Profile

Actions
Copy link

Bug #65176

open

BlueFS: _estimate_log_size_N calculates the log size incorrectly

Added by linke wang about 1 month ago. Updated 13 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
squid, reef, quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
56515
Crash signature (v1):
Crash signature (v2):

Description

In BlueFS::_estimate_log_size_N, the total size of the dir was calculated incorrectly.
It should be the number of dirs multiplied by (avg_size+1).

Actions
Copy link
 #1

Updated by Igor Fedotov about 1 month ago

  • Status changed from New to In Progress
  • Backport set to squid, reef, quincy
Actions
Copy link
 #2

Updated by linke wang 24 days ago

Does avg_dir_size or avg_file_size represent the meaning of the bytes occupied by the name? Or does it have other meanings? @ Igor Fedotov

Actions
Copy link
 #3

Updated by Igor Fedotov 24 days ago

linke wang wrote in #note-2:

Does avg_dir_size or avg_file_size represent the meaning of the bytes occupied by the name? Or does it have other meanings? @ Igor Fedotov

Yeah, looks like they represent bytes occupied for names. Not sure I understand why we sum avg_dir_size and avg_file_size for the following line though:
size += nodes.file_map.size() * (1 + avg_dir_size + avg_file_size);

Actions
Copy link
 #4

Updated by linke wang 13 days ago

What is calculated here should be the total bytes occupied by the names of all files.@ Igor Fedotov

Actions
Copy link

Also available in: Atom PDF