Actions
Bug #64533
openBlueFS: l_bluefs_log_compactions is counted twice in sync log compaction
% Done:
0%
Source:
Community (user)
Tags:
backport_processed
Backport:
squid, reef, quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Description
When sync log compaction, in BlueFS::_compact_log_sync_LNF_LD, l_bluefs_log_compactions is first counted in _rewrite_log_and_layout_sync_LNF_LD.
After _rewrite_log_and_layout_sync_LNF_LD, l_bluefs_log_compactions is second counted.
@Bingrun Liu BlueFS::_compact_log_sync_LNF_LD()
{
dout(10) << func << dendl;
uint8_t prefer_bdev;
{
std::lock_guard ll(log.lock);
prefer_bdev =
vselector->select_prefer_bdev(log.writer->file->vselector_hint);
}
_rewrite_log_and_layout_sync_LNF_LD(true, //here is first counted
BDEV_DB,
prefer_bdev,
prefer_bdev,
0,
super.memorized_layout);
logger->inc(l_bluefs_log_compactions); // here is second counted
}
@
Updated by Igor Fedotov 2 months ago
- Status changed from New to Pending Backport
- Backport set to squid, reef, quincy
Updated by Backport Bot 2 months ago
- Copied to Backport #64590: reef: BlueFS: l_bluefs_log_compactions is counted twice in sync log compaction added
Updated by Backport Bot 2 months ago
- Copied to Backport #64591: squid: BlueFS: l_bluefs_log_compactions is counted twice in sync log compaction added
Updated by Backport Bot 2 months ago
- Copied to Backport #64592: quincy: BlueFS: l_bluefs_log_compactions is counted twice in sync log compaction added
Updated by Konstantin Shalygin 8 days ago
- Assignee set to linke wang
- Target version set to v20.0.0
- Source set to Community (user)
Actions