Actions
Bug #6427
closedceph-deply osd activate breaks on error
% Done:
0%
Source:
Community (user)
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
There are undefined variables for this command that attempt to construct the error messaging
[ceph_deploy.osd][DEBUG ] Activating cluster ceph disks ceph.host.name:/dev/sdb: [ceph_deploy.sudo_pushy][DEBUG ] will use a remote connection with sudo [ceph_deploy.osd][DEBUG ] Activating host ceph.host.name disk /dev/sdb [ceph_deploy.osd][DEBUG ] Distro RedHatEnterpriseServer codename Santiago, will use sysvinit Traceback (most recent call last): File "/usr/bin/ceph-deploy", line 21, in <module> sys.exit(main()) File "/usr/lib/python2.6/site-packages/ceph_deploy/util/decorators.py", line 83, in newfunc return f(*a, **kw) File "/usr/lib/python2.6/site-packages/ceph_deploy/cli.py", line 147, in main return args.func(args) File "/usr/lib/python2.6/site-packages/ceph_deploy/osd.py", line 379, in disk activate(args, cfg) File "/usr/lib/python2.6/site-packages/ceph_deploy/osd.py", line 271, in activate cmd=cmd, ret=ret, out=out, err=err) NameError: global name 'ret' is not defined
Updated by Alfredo Deza over 10 years ago
- Status changed from 12 to Fix Under Review
Pull request opened: https://github.com/ceph/ceph-deploy/pull/93
Updated by Alfredo Deza over 10 years ago
- Status changed from Fix Under Review to Resolved
Merged into ceph-deploy master branch with hash: 4a9ed622913f82c75849de2e5ebcb20e26fb605f
Migrated the whole function to use the newer connection methods that also fix how we report them.
Actions