Ceph » rgw

i was able to reproduce this by modifying the following s3-tests case:

~/s3-tests $ git diff
diff --git a/s3tests_boto3/functional/test_s3.py b/s3tests_boto3/functional/test_s3.py
index 1273d8a..8a2c501 100644
--- a/s3tests_boto3/functional/test_s3.py
+++ b/s3tests_boto3/functional/test_s3.py
@@ -11776,9 +11776,11 @@ def test_object_lock_put_obj_retention():
     key = 'file1'
     response = client.put_object(Bucket=bucket_name, Body='abc', Key=key)
     version_id = response['VersionId']
-    retention = {'Mode':'GOVERNANCE', 'RetainUntilDate':datetime.datetime(2030,1,1,tzinfo=pytz.UTC)}
+    retention = {'Mode':'GOVERNANCE', 'RetainUntilDate':datetime.datetime(2141,1,1,tzinfo=pytz.UTC)}
     response = client.put_object_retention(Bucket=bucket_name, Key=key, Retention=retention)
     assert response['ResponseMetadata']['HTTPStatusCode'] == 200
+    response = client.get_object_retention(Bucket=bucket_name, Key=key)
+    assert response['Retention'] == retention
     client.delete_object(Bucket=bucket_name, Key=key, VersionId=version_id, BypassGovernanceRetention=True)

>       assert response['Retention'] == retention
E       AssertionError: assert {'Mode': 'GOV...info=tzutc())} == {'Mode': 'GOV...tzinfo=<UTC>)}
E         Omitting 1 identical items, use -vv to show                                                                                                         
E         Differing items:   
E         {'RetainUntilDate': datetime.datetime(2004, 11, 24, 17, 31, 44, tzinfo=tzutc())} != {'RetainUntilDate': datetime.datetime(2141, 1, 1, 0, 0, tzinfo=<
UTC>)}

debug logging shows that ceph::from_iso_8601() parses the date correctly, but binary encode/decode corrupts the date:

RetainUntilDate "2141-01-01T00:00:00Z" parsed as  2140-12-31T19:00:00.000000-0500
encoding retain_until_date 2140-12-31T19:00:00.000000-0500
...
decoded retain_until_date 2004-11-24T12:31:44.000000-0500
RetainUntilDate "2004-11-24T12:31:44.000000-0500" formatted as 2004-11-24T17:31:44.000000000Z

it looks like the binary encoding for these timestamps is truncating seconds to 32 bits in https://github.com/ceph/ceph/blob/d9a4752/src/include/encoding.h#L332-L336:

  // A 32 bit count of seconds causes me vast unhappiness.
  uint32_t s = ts.tv_sec;