Bug #63150: Reef: mgr/cephadm: container image name contains tag but should not - Orchestrator - Ceph

Actions

Copy link

Bug #63150

closed

Reef: mgr/cephadm: container image name contains tag but should not

Added by Eugen Block 7 months ago. Updated 5 months ago.

Status:

Resolved

Priority:

Normal

Assignee:

Adam King

Category:

Target version:

Ceph - v18.2.1

% Done:

100%

Source:

Community (user)

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

53922

Crash signature (v1):

Crash signature (v2):

Description

While responding to a ceph-users mailing list thread I investigated the issue and figured that the default value for mgr/cephadm/container_image_base has been changed from quay.io/ceph/ceph to quay.io/ceph/ceph:v18 between Quincy and Reef.
This results in errors for upgrade checks/starts:

$ ceph orch upgrade check --ceph-version 18.2.0
Error EINVAL: host nautilus `cephadm pull` failed: cephadm exited with an error code: 1, stderr: Pulling container image quay.io/ceph/ceph:v18:v18.2.0...
Non-zero exit code 125 from /usr/bin/podman pull quay.io/ceph/ceph:v18:v18.2.0 --authfile=/etc/ceph/podman-auth.json
/usr/bin/podman: stderr Error: invalid reference format
ERROR: Failed command: /usr/bin/podman pull quay.io/ceph/ceph:v18:v18.2.0 --authfile=/etc/ceph/podman-auth.json

A quick workaround would be to set it to the previous default:

ceph config set mgr mgr/cephadm/container_image_base quay.io/ceph/ceph

Apparently, this is the responsible change:

# Quincy
grep "DEFAULT_IMAGE\ =" /usr/share/ceph/mgr/cephadm/module.py
DEFAULT_IMAGE = 'quay.io/ceph/ceph'

# Reef
grep "DEFAULT_IMAGE\ =" /usr/share/ceph/mgr/cephadm/module.py
DEFAULT_IMAGE = 'quay.io/ceph/ceph:v18'

Although the description clearly states:

Option(
            'container_image_base',
            default=DEFAULT_IMAGE,
            desc='Container image name, without the tag',

Actions

Copy link

Updated by Venky Shankar 7 months ago

Project changed from CephFS to Orchestrator

This isn't cephfs - moving to orch.

Actions

Copy link

Updated by Eugen Block 7 months ago

Oops, I hit the submit button too early, I didn't realize it was assigned to the CephFS project (is that the default when creating a new issue?). Also I forgot to add a proper subject, could you please edit the subject because I'm not allowed to do that. Something like "Reef: container default image contains tag" would make sense.

Actions

Copy link

Updated by John Mulligan 7 months ago

Subject changed from Reef: to Reef: mgr/cephadm: container image name contains tag but should not

Here's the commit that added the tag 198ca7bc679e38e77bfb2c5b257f34bf42112af0.

I think the issue arose because cephadm should contain a tag but the mgr module value should not. But that's inconsistent and most likely created some confusion about what to change on the reef branch.

Actions

Copy link